Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: debugger improvements 2 #6494

Merged
merged 2 commits into from
Dec 1, 2023
Merged

chore: debugger improvements 2 #6494

merged 2 commits into from
Dec 1, 2023

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Dec 1, 2023

Motivation

Follow-up to #6491

No functional changes, just clean up around terminal init by using RAII.
Bad diff because of moving to new file :(

Solution

@DaniPopes DaniPopes force-pushed the dani/debugger-stuff2 branch 2 times, most recently from a73c1fc to 2b21b3a Compare December 1, 2023 22:12
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a lot cleaner, ty.

only nits

crates/anvil/src/service.rs Outdated Show resolved Hide resolved
Comment on lines +407 to +412
let mut debugger = DebuggerBuilder::new()
.debug_arena(&result.debug)
.decoder(&decoder)
.sources(sources)
.build()?;
debugger.try_run()?;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this

Comment on lines +27 to +31
/// Creates a new debugger builder.
#[inline]
pub fn new() -> Self {
Self::default()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally, I think new -> default is redundant

crates/evm/core/src/fork/backend.rs Outdated Show resolved Hide resolved
crates/evm/core/src/fork/multi.rs Outdated Show resolved Hide resolved
@DaniPopes DaniPopes marked this pull request as ready for review December 1, 2023 22:38
@DaniPopes DaniPopes merged commit 5b7e4cb into master Dec 1, 2023
19 checks passed
@DaniPopes DaniPopes deleted the dani/debugger-stuff2 branch December 1, 2023 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants